feat(deploy-docs): add new input variable to select mkdocs-requirements #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki AKAMINE <[email protected]>
|
@kenji-miyake |
Signed-off-by: Takayuki AKAMINE <[email protected]>
kenji-miyake
reviewed
Jun 9, 2022
kenji-miyake
reviewed
Jun 9, 2022
kenji-miyake
reviewed
Jun 9, 2022
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
|
@kenji-miyake |
|
@takam5f2 Have you tested this PR? |
|
@kenji-miyake Both worked properly as explained in |
|
Cool! Thank you! |
kenji-miyake
approved these changes
Jun 9, 2022
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takayuki AKAMINE [email protected]
Description
I'd like to update
deploy-docsto give customizedmkdocs-requirements.txt. The default requirements file${GITHUB_ACTION_PATH}/mkdocs-requirements.txt}will be used if users don't describe any input file.I've tested this change with two patterns; using default
mkdocs-requirements.txtand using customized one.Default requirements.txt :
${GITHUB_ACTION_PATH}/mkdocs-requirements.txt}(like CARET_doc)pip3 installcommand was executed with${GITHUB_ACTION_PATH}/mkdocs-requirements.txt}Customized requirements.txt :
./mkdocs-requirements.txt(like CARET_analyze)pip3 installcommand was executed with./mkdocs-requirements.txtdeploy-docsis failed due to another reason not related to this PRPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.