-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deploy-docs): add new input variable to select mkdocs-requirements #164
feat(deploy-docs): add new input variable to select mkdocs-requirements #164
Conversation
Signed-off-by: Takayuki AKAMINE <[email protected]>
@kenji-miyake |
Signed-off-by: Takayuki AKAMINE <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
@kenji-miyake |
@takam5f2 Have you tested this PR? |
@kenji-miyake Both worked properly as explained in |
Cool! Thank you! |
Signed-off-by: Takayuki AKAMINE [email protected]
Description
I'd like to update
deploy-docs
to give customizedmkdocs-requirements.txt
. The default requirements file${GITHUB_ACTION_PATH}/mkdocs-requirements.txt}
will be used if users don't describe any input file.I've tested this change with two patterns; using default
mkdocs-requirements.txt
and using customized one.Default requirements.txt :
${GITHUB_ACTION_PATH}/mkdocs-requirements.txt}
(like CARET_doc)pip3 install
command was executed with${GITHUB_ACTION_PATH}/mkdocs-requirements.txt}
Customized requirements.txt :
./mkdocs-requirements.txt
(like CARET_analyze)pip3 install
command was executed with./mkdocs-requirements.txt
deploy-docs
is failed due to another reason not related to this PRPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.