Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync-files): run pre-commands before if-condition #167

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Jun 13, 2022

Description

  • To calculate the diff correctly, run pre-commands before if-condition.
  • Remove || true because it isn't planned to be used for now.
    • I think using {dest} in pre-command is a super-advanced use case.
  • Fix comments.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Kenji Miyake added 3 commits June 13, 2022 10:32
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
@kenji-miyake kenji-miyake merged commit 5c484fc into main Jun 13, 2022
@kenji-miyake kenji-miyake deleted the fix-sync-files branch June 13, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants