Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(clang-tidy): support target files input #178

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Aug 31, 2022

Description

Currently, many files are checked in the workflow, but it's too slow.
So I'd like to support the target-files input to limit the target files to be analyzed.

https://github.com/autowarefoundation/autoware.universe/runs/8107659485?check_suite_focus=true#step:6:252

image

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Kenji Miyake added 2 commits August 31, 2022 17:00
@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Aug 31, 2022

I'll test this in another PR to autoware.universe.
-> autowarefoundation/autoware.universe#1745

fix
Signed-off-by: Kenji Miyake <[email protected]>
@kenji-miyake
Copy link
Contributor Author

@kenji-miyake kenji-miyake marked this pull request as ready for review August 31, 2022 12:01
@kenji-miyake kenji-miyake merged commit bd16c65 into main Sep 1, 2022
@kenji-miyake kenji-miyake deleted the update-clang-tidy branch September 1, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants