feat(semantic-pull-request): disable validateSingleCommit #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenji Miyake <[email protected]>
kenji-miyake
force-pushed
the
disable-validateSingleCommit
branch
from
ddc304c
to
24e066b
Compare
|
Note: The maintainers should change this option to either one in the red square. |
Merged
4 tasks
|
@xmfcx Could you review this? 🙏 |
|
I suppose it's okay for @xmfcx. |
|
Ah thanks, it's ok. It was in draft, forgot to approve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #148, I think we can also remove
validateSingleCommitnow. I just forgot to remove it.action-semantic-pull-requestensures that the PR title is semantic.https://github.com/amannn/action-semantic-pull-request/blob/4682b170e7c31dfbef288e994fe07853755229b4/src/index.js#L67
With this PR, we can remove this part in the pull request guidelines.
https://github.com/autowarefoundation/autoware-documentation/blob/af6c4d1b2c0747aa93f5c50899fa0c07e93b6d21/docs/contributing/pull-request-guidelines/index.md?plain=1#L74-L76
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.