Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clang-tidy, colcon-build): make CMAKE_BUILD_TYPE optional #185

Merged
merged 3 commits into from
Sep 28, 2022
Merged

feat(clang-tidy, colcon-build): make CMAKE_BUILD_TYPE optional #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35705f9
fix(clang-tidy, colcon-build): use RelWithDebInfo for CMAKE_BUILD_TYPE
Sep 27, 2022
b831777
use Debug
Sep 27, 2022
f0e6bfd
make cmake-build-type optional
Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang-tidy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
| target-packages | true | The target packages to analyze by Clang-Tidy. |
| target-files | false | The target files. |
| build-depends-repos | false | The `.repos` file that includes build dependencies. |
| cmake-build-type | false | The value for `CMAKE_BUILD_TYPE`. |
| token | false | The token for build dependencies and `.clang-tidy`. |

## Outputs
Expand Down
6 changes: 5 additions & 1 deletion clang-tidy/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ inputs:
build-depends-repos:
description: ""
required: false
cmake-build-type:
description: ""
required: false
default: Release
token:
description: ""
required: false
Expand Down Expand Up @@ -85,7 +89,7 @@ runs:
. /opt/ros/${{ inputs.rosdistro }}/setup.sh
colcon build --event-handlers console_cohesion+ \
--packages-up-to ${{ inputs.target-packages }} \
--cmake-args -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
--cmake-args -DCMAKE_BUILD_TYPE=${{ inputs.cmake-build-type }} -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
shell: bash

- name: Retrieve .clang-tidy
Expand Down
1 change: 1 addition & 0 deletions colcon-build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
| rosdistro | true | ROS distro. |
| target-packages | true | The target packages to build. |
| build-depends-repos | false | The `.repos` file that includes build dependencies. |
| cmake-build-type | false | The value for `CMAKE_BUILD_TYPE`. |
| token | false | The token for build dependencies. |

## Outputs
Expand Down
6 changes: 5 additions & 1 deletion colcon-build/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ inputs:
build-depends-repos:
description: ""
required: false
cmake-build-type:
description: ""
required: false
default: Release
token:
description: ""
required: false
Expand Down Expand Up @@ -62,7 +66,7 @@ runs:
. /opt/ros/${{ inputs.rosdistro }}/setup.sh
colcon build --event-handlers console_cohesion+ \
--packages-above-and-dependencies ${{ inputs.target-packages }} \
--cmake-args -DCMAKE_BUILD_TYPE=Release \
--cmake-args -DCMAKE_BUILD_TYPE=${{ inputs.cmake-build-type }} \
--mixin coverage-gcc coverage-pytest compile-commands
shell: bash

Expand Down