Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clang-tidy): make clang-tidy workflow fail only when it reports errors #306

Merged
merged 2 commits into from
Jul 1, 2024
+13 −5
Merged

fix(clang-tidy): make clang-tidy workflow fail only when it reports errors #306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4185b42
fix(clang-tidy): make clang-tidy workflow fail only when it reports e…
veqcc Jun 28, 2024
90a0f2a
restore fixes.yaml
veqcc Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions clang-tidy/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,27 +126,35 @@ runs:
if: ${{ steps.get-target-files.outputs.target-files != '' }}
run: |
mkdir /tmp/clang-tidy-result
clang-tidy -p build/ -export-fixes /tmp/clang-tidy-result/fixes.yaml ${{ steps.get-target-files.outputs.target-files }} || true
clang-tidy -p build/ -export-fixes /tmp/clang-tidy-result/fixes.yaml ${{ steps.get-target-files.outputs.target-files }} > /tmp/clang-tidy-result/report.txt || true
echo "${{ github.event.number }}" > /tmp/clang-tidy-result/pr-id.txt
echo "${{ github.event.pull_request.head.repo.full_name }}" > /tmp/clang-tidy-result/pr-head-repo.txt
echo "${{ github.event.pull_request.head.ref }}" > /tmp/clang-tidy-result/pr-head-ref.txt
shell: bash

- name: Check if the report.txt file exists
id: check-report-txt-existence
uses: autowarefoundation/autoware-github-actions/check-file-existence@v1
with:
files: /tmp/clang-tidy-result/report.txt

- name: Check if the fixes.yaml file exists
id: check-fixes-yaml-existence
uses: autowarefoundation/autoware-github-actions/check-file-existence@v1
with:
files: /tmp/clang-tidy-result/fixes.yaml

- name: Upload artifacts
if: ${{ steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
if: ${{ steps.check-report-txt-existence.outputs.exists == 'true' && steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
uses: actions/upload-artifact@v4
with:
name: clang-tidy-result
path: /tmp/clang-tidy-result/

- name: Mark the workflow as failed if the fixes.yaml file exists
if: ${{ steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
- name: Mark the workflow as failed if clang-tidy find an error
if: ${{ steps.check-report-txt-existence.outputs.exists == 'true' }}
run: |
exit 1
if [ -n "$(grep ": error:" /tmp/clang-tidy-result/report.txt)" ]; then
exit 1
fi
shell: bash
Loading