Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation node for the planning trajectory #2605

Closed
3 tasks done
TakaHoribe opened this issue Jan 2, 2023 · 7 comments
Closed
3 tasks done

Add a validation node for the planning trajectory #2605

TakaHoribe opened this issue Jan 2, 2023 · 7 comments
Assignees
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@TakaHoribe
Copy link
Contributor

TakaHoribe commented Jan 2, 2023

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Sometimes, a faulty path is published due to the poor quality of the planning. This can cause the vehicle to behave abnormally in terms of steering, acceleration, and braking. It is important to continually improve the quality of the planning, but we also need to implement a validation system to ensure the quality of the paths being published.

Purpose

To avoid publishing abnormal paths.

Possible approaches

A planning validator node is introduced at the final stage of the planning process. The node validates the trajectory and stops publishing if it is invalid.

The planning node diagram would be like below:
planning_modules -> planning_validator -> control.

image

Definition of done

A validation mechanism of the planning is in the autoware.

@TakaHoribe TakaHoribe self-assigned this Jan 2, 2023
@TakaHoribe TakaHoribe added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 2, 2023
@TakaHoribe
Copy link
Contributor Author

TakaHoribe commented Jan 2, 2023

cc. @yukkysaito @xmfcx

@BonoloAWF BonoloAWF added the type:bug Software flaws or errors. label Jan 5, 2023
@TakaHoribe TakaHoribe added type:new-feature New functionalities or additions, feature requests. and removed type:bug Software flaws or errors. labels Jan 10, 2023
@yukkysaito
Copy link
Contributor

I think it's a good idea to add one.
However, I would like to separate what is verified online and what is verified offline (like CI)
Otherwise, it would be inefficient to run a huge verification online.

@TakaHoribe
Copy link
Contributor Author

to separate what is verified online and what is verified offline (like CI)

Ok. In the first phase, the validator node focus only on the online checks (curvature, acceleration, etc). The offline validation item could be something regarding the map, kinematics parameters, etc. We should discuss this further.

@stale
Copy link

stale bot commented Mar 19, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 19, 2023
@mehmetdogru
Copy link
Contributor

@TakaHoribe I guess this issue can be closed?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Mar 29, 2023
@TakaHoribe
Copy link
Contributor Author

This can be closed with these PRs.
#2605 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants