Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs about euclidean_cluster #7587

Closed
3 tasks done
beginningfan opened this issue Jun 19, 2024 · 1 comment
Closed
3 tasks done

Bugs about euclidean_cluster #7587

beginningfan opened this issue Jun 19, 2024 · 1 comment
Assignees
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)

Comments

@beginningfan
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

  1. min_cluster_size is not passed to clustering algorithm
  2. When the max_cluster_size_ is large, clustering takes too much CPU and memory because this line. This bug is related to this pr

Expected behavior

  1. The size of the cluster is greater than or equal to the min_cluster_size
  2. Memory allocation should be based on the actual size of the point cloud

Actual behavior

  1. The input parameter of the cluster algorithm is 1
  2. Memory allocation is based on the maximum number of clusters

Steps to reproduce

  1. print size of clusters before filter in here
  2. use a large number such as 30000 as max_cluster_size in config

Versions

OS: ROS2
autoware: latest

Possible causes

No response

Additional context

No response

@beginningfan beginningfan added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 20, 2024
@beginningfan beginningfan self-assigned this Jun 21, 2024
@badai-nguyen
Copy link
Contributor

@beginningfan thank you for your raising issue,
Regarding to your 1.

min_cluster_size is not passed to clustering algorithm

I think that min_cluster_size was passed and used to check clusters' size here:

if (!(min_cluster_size_ <= static_cast<int>(i_cluster_data_size / point_step) &&
static_cast<int>(i_cluster_data_size / point_step) <= max_cluster_size_)) {
continue;

Could check it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants