Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): separate data #1209

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 1, 2022

Signed-off-by: yutaka [email protected]

Description

Separate Cruise and Stop Data for obstacle cruise planner and clean the code.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1209 (ba96795) into main (791fd51) will decrease coverage by 0.02%.
The diff coverage is 1.36%.

@@           Coverage Diff            @@
##            main   #1209      +/-   ##
========================================
- Coverage   9.56%   9.53%   -0.03%     
========================================
  Files       1049    1049              
  Lines      72107   72298     +191     
  Branches   15601   15601              
========================================
  Hits        6896    6896              
- Misses     58962   59153     +191     
  Partials    6249    6249              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.54% <1.81%> (ø) Carriedforward from 791fd51

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
...ation_based_planner/optimization_based_planner.hpp 0.00% <ø> (ø)
...se_planner/pid_based_planner/pid_based_planner.hpp 0.00% <ø> (ø)
...lude/obstacle_cruise_planner/planner_interface.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...ation_based_planner/optimization_based_planner.cpp 0.00% <0.00%> (ø)
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% <0.00%> (ø)
...ollower_nodes/src/longitudinal_controller_node.cpp 38.56% <25.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18af5b4...ba96795. Read the comment docs.

@purewater0901 purewater0901 merged commit 27e7072 into autowarefoundation:main Jul 4, 2022
@purewater0901 purewater0901 deleted the feat/separate-cruise-stop-data branch July 4, 2022 03:44
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Apr 10, 2024
…k-planning-validator

fix(planning_validator): cherry-pick numerically safe calculation of max lateral acceleration for MRM check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants