-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to use validator node in detection module #1233
feat: add option to use validator node in detection module #1233
Conversation
Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
launch/tier4_perception_launch/launch/object_recognition/detection/detection.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: tomoya.kimura <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1233 +/- ##
=====================================
Coverage 9.52% 9.52%
=====================================
Files 1051 1051
Lines 72465 72465
Branches 15776 15776
=====================================
Hits 6905 6905
Misses 59280 59280
Partials 6280 6280
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
* Ros2 v0.8.0 topic state monitor (autowarefoundation#283) * Add node_name_suffix to topic_state_monitor.launch (autowarefoundation#1157) (autowarefoundation#370) Signed-off-by: Kenji Miyake <[email protected]> * fix launch file (autowarefoundation#411) * add transient local option to topic state monitor (autowarefoundation#410) * add transient local option to topic state monitor * sort parameters * sort parameter * [topic_state_monitor]: Add best effort option (autowarefoundation#430) Signed-off-by: autoware <[email protected]> Co-authored-by: autoware <[email protected]> * add use_sim-time option (autowarefoundation#454) * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <[email protected]> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <[email protected]> * change to composable node (autowarefoundation#1233) * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <[email protected]> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <[email protected]> * Fix variable names Signed-off-by: Kenji Miyake <[email protected]> * Use integrated generic subscription (autowarefoundation#1342) Signed-off-by: wep21 <[email protected]> * suppress warnings for declare parameters (autowarefoundation#1724) * fix for lanelet2_extension * fix for traffic light ssd fine detector * fix for topic_state_monitor * fix for dummy diag publisher * fix for remote cmd converter * fix for vehicle_info_util * fix for multi object tracker * fix for freespace planner * fix for autoware_error_monitor * add Werror for multi object tracker * fix for multi object tracker * add Werror for liraffic light ssd fine detector * add Werror for topic state monitor * add Werror * add Werror * add Werror * add Werror * fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <[email protected]> * Fix mistake Signed-off-by: Kenji Miyake <[email protected]> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <[email protected]> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <[email protected]> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <[email protected]> * Apply Black Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <[email protected]> * remove COLCON_IGNORE in system_packages and map_tf_generator (autowarefoundation#532) * [topic_state_monitor]add readme (autowarefoundation#565) * add readme * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <[email protected]> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <[email protected]> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <[email protected]> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <[email protected]> * Update system/topic_state_monitor/Readme.md Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: autoware <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Taichi Higashide <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takeshi Miura <[email protected]> Co-authored-by: taikitanaka3 <[email protected]>
* feat: add option to use validator node in detection module Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> * remove use_validator option in detection/perception.launch Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]>
* feat: add option to use validator node in detection module Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> * remove use_validator option in detection/perception.launch Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]>
* feat: add option to use validator node in detection module Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> * remove use_validator option in detection/perception.launch Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]>
…oundation#1233) * feat: add option to use validator node in detection module Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> * remove use_validator option in detection/perception.launch Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]>
* feat: add option to use validator node in detection module Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]> * remove use_validator option in detection/perception.launch Signed-off-by: tomoya.kimura <[email protected]> * fix Signed-off-by: tomoya.kimura <[email protected]>
Description
Add option to use validator node in detection module
Review Procedure
$ ros2 launch tier4_perception_launch perception.launch.xml mode:=lidar/camera_lidar_fusion use_validator:=true/false
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.