fix(simple_planning_simulator): fix param file levels #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1612 +/- ##
=======================================
Coverage 10.68% 10.68%
=======================================
Files 1109 1109
Lines 78589 78589
Branches 18553 18553
=======================================
Hits 8401 8401
Misses 61321 61321
Partials 8867 8867
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Haoru Xue <[email protected]>
HaoruXue
force-pushed
the
fix-simple-sim-param
branch
from
daee9da
to
666f88c
Compare
|
LGTM. @TakaHoribe @yukkysaito Could you approve this PR. |
|
@TakaHoribe Pls double check |
TakaHoribe
approved these changes
Sep 9, 2022
voltonomous
pushed a commit
to vautonomous/autoware.universe
that referenced
this pull request
Sep 11, 2022
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Sep 28, 2022
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haoru Xue [email protected]
Description
Fix a bug in
simple_planning_simulatorwhere the parameters in the param files are not correctly loaded into the node. The issue was not previously apparent because every parameter has a default value.How to replicate:
simple_planning_simulator_core.cpp, remove a default value in a paramter declaration, for example,vehicle_model_typeros2 launch simple_planning_simulator simple_planning_simulator.launch.py initial_engage_state:=truePre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.