-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(simple_planning_simulator): fix param file levels #1612
fix(simple_planning_simulator): fix param file levels #1612
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1612 +/- ##
=======================================
Coverage 10.68% 10.68%
=======================================
Files 1109 1109
Lines 78589 78589
Branches 18553 18553
=======================================
Hits 8401 8401
Misses 61321 61321
Partials 8867 8867
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Haoru Xue <[email protected]>
daee9da
to
666f88c
Compare
LGTM. @TakaHoribe @yukkysaito Could you approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TakaHoribe Pls double check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed it worked with
ros2 launch simple_planning_simulator simple_planning_simulator.launch.py initial_engage_state:=false
LGTM. Thank you!
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
…tion#1612) Signed-off-by: Haoru Xue <[email protected]> Signed-off-by: Haoru Xue <[email protected]>
Signed-off-by: Haoru Xue [email protected]
Description
Fix a bug in
simple_planning_simulator
where the parameters in the param files are not correctly loaded into the node. The issue was not previously apparent because every parameter has a default value.How to replicate:
simple_planning_simulator_core.cpp
, remove a default value in a paramter declaration, for example,vehicle_model_type
ros2 launch simple_planning_simulator simple_planning_simulator.launch.py initial_engage_state:=true
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.