Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(tier4_state_rviz_plugin): readability-identifier-naming (#1595) #1617

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 18, 2022

Description

This reverts commit 5772020.
Fix buttons in the panel are not worked.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta changed the title Revert "refactor(tier4_state_rviz_plugin): apply clang-tidy for readability-identifier-naming (#1595) Revert: refactor(tier4_state_rviz_plugin): apply clang-tidy for readability-identifier-naming (#1595) Aug 18, 2022
@h-ohta h-ohta changed the title Revert: refactor(tier4_state_rviz_plugin): apply clang-tidy for readability-identifier-naming (#1595) revert: refactor(tier4_state_rviz_plugin): apply clang-tidy for readability-identifier-naming (#1595) Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1617 (78f6bfb) into main (219af03) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   10.76%   10.76%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       78546    78597      +51     
  Branches    18554    18554              
==========================================
  Hits         8459     8459              
- Misses      61226    61277      +51     
  Partials     8861     8861              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (ø) Carriedforward from 219af03

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta force-pushed the revert/tier4_state_rviz_plugin branch from bb1a955 to 78f6bfb Compare August 18, 2022 08:26
@h-ohta h-ohta changed the title revert: refactor(tier4_state_rviz_plugin): apply clang-tidy for readability-identifier-naming (#1595) reverttier4_state_rviz_plugin): readability-identifier-naming (#1595) Aug 18, 2022
@h-ohta h-ohta changed the title reverttier4_state_rviz_plugin): readability-identifier-naming (#1595) revert(tier4_state_rviz_plugin): readability-identifier-naming (#1595) Aug 18, 2022
@taikitanaka3 taikitanaka3 merged commit c209663 into autowarefoundation:main Aug 18, 2022
@h-ohta h-ohta deleted the revert/tier4_state_rviz_plugin branch August 18, 2022 10:07
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…#1595) (autowarefoundation#1617)

revert(tier4_state_rviz_plugin): readability-identifier-naming (tier4#1595)"

This reverts commit 5772020.
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…#1595) (autowarefoundation#1617)

revert(tier4_state_rviz_plugin): readability-identifier-naming (tier4#1595)"

This reverts commit 5772020.
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…#1595) (autowarefoundation#1617)

revert(tier4_state_rviz_plugin): readability-identifier-naming (tier4#1595)"

This reverts commit 5772020.
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…#1595) (autowarefoundation#1617)

revert(tier4_state_rviz_plugin): readability-identifier-naming (tier4#1595)"

This reverts commit 5772020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants