Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_perception_rviz_plugin): apply clang-tidy #1624

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 18, 2022

Description

  • apply NOLINT for readability-redundant-access-specifiers due to Qt
  • fix below
    • clang-diagnostic-inconsistent-missing-override
    • modernize-use-override
    • modernize-use-nodiscard
    • bugprone-parent-virtual-call
    • cppcoreguidelines-pro-type-member-init
  • delete destructor which has no definition

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1624 (09937b9) into main (ce8f2c3) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
- Coverage   11.05%   10.79%   -0.27%     
==========================================
  Files        1035     1109      +74     
  Lines       69357    78446    +9089     
  Branches    17985    18555     +570     
==========================================
+ Hits         7670     8465     +795     
- Misses      53251    61124    +7873     
- Partials     8436     8857     +421     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.78% <0.00%> (-0.28%) ⬇️ Carriedforward from 61f6972

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_perception_rviz_plugin/src/tools/car_pose.cpp 0.00% <0.00%> (ø)
...ption_rviz_plugin/src/tools/delete_all_objects.hpp 0.00% <0.00%> (ø)
...ption_rviz_plugin/src/tools/interactive_object.cpp 0.00% <ø> (ø)
...ption_rviz_plugin/src/tools/interactive_object.hpp 0.00% <0.00%> (ø)
...rception_rviz_plugin/src/tools/pedestrian_pose.cpp 0.00% <0.00%> (ø)
..._perception_rviz_plugin/src/tools/unknown_pose.cpp 0.00% <0.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...tic_evaluator/include/kinematic_evaluator/stat.hpp 62.50% <0.00%> (-19.32%) ⬇️
..._evaluator/include/localization_evaluator/stat.hpp 56.25% <0.00%> (-16.48%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
... and 768 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta enabled auto-merge (squash) August 18, 2022 12:53
@h-ohta h-ohta merged commit 9ec557d into autowarefoundation:main Aug 18, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@h-ohta h-ohta deleted the refactor/tier4_perception_rviz_plugin branch October 17, 2022 05:45
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 28, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 15, 2022
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 18, 2023
…ndation#1624)

* refactor(tier4_perception_rviz_plugin): apply clang-tidy

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants