Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add point to tfvector function #1726

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 30, 2022

Signed-off-by: yutaka [email protected]

Description

Add point2tfVector functions that are duplicated in obstacle_cruise_planner and motion_velocity_smoother.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1726 (e66973b) into main (74e28ed) will increase coverage by 0.21%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
+ Coverage   10.25%   10.47%   +0.21%     
==========================================
  Files        1204     1204              
  Lines       86697    86973     +276     
  Branches    20020    20195     +175     
==========================================
+ Hits         8894     9107     +213     
+ Misses      68541    68538       -3     
- Partials     9262     9328      +66     
Flag Coverage Δ *Carryforward flag
differential 11.67% <35.71%> (?)
total 10.24% <76.47%> (ø) Carriedforward from 74e28ed

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...autoware_utils/test/src/geometry/test_geometry.cpp 49.66% <67.56%> (+6.64%) ⬆️
...include/tier4_autoware_utils/geometry/geometry.hpp 95.83% <100.00%> (+0.21%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 83.01% <0.00%> (+9.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@purewater0901 purewater0901 merged commit 1d10ff3 into autowarefoundation:main Aug 30, 2022
@purewater0901 purewater0901 deleted the feat/add-point2tfvector-function branch August 30, 2022 06:37
TakaHoribe pushed a commit to TakaHoribe/autoware.universe that referenced this pull request Sep 5, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants