Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): use intersection_area if available #1733

Merged
merged 16 commits into from
Sep 20, 2022

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 30, 2022

Description

If the intersection_area is set at the intersection and each lanelet is associated with it, use it for detection.

  • if not set, use detection_area_with_margin as before
  • if set, use intersection_area additionally

If area is available it will be visualized as the debug marker.

Screenshot from 2022-09-05 22-14-12

How it works

  • if the object is in intersection_area
    • if it is in adjacent_lanes, it is not detected
    • else it is detected
  • else if it is in detection_area, detect this

Tests performed

In the movie if the object is in adjacent_lanes (orange aera) it is not detected in intersection module. Otherwise it is detected if it is in intersectsion_area (in most cases its prediction path does not collide with ego's path).

intersection_area_adjacnet_lanes-2022-09-05_23.33.15.mp4

Notes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin force-pushed the feat/intersection-area branch 2 times, most recently from d121bce to f6d92ea Compare August 30, 2022 15:47
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 10.35% // Head: 10.04% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (2640ddb) compared to base (d181522).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   10.35%   10.04%   -0.31%     
==========================================
  Files        1146     1255     +109     
  Lines       81448    90514    +9066     
  Branches    19003    20662    +1659     
==========================================
+ Hits         8433     9094     +661     
- Misses      63895    72006    +8111     
- Partials     9120     9414     +294     
Flag Coverage Δ *Carryforward flag
differential 4.26% <0.00%> (?)
total 10.07% <0.00%> (-0.27%) ⬇️ Carriedforward from 0bf3bf8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp 70.90% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/cuda_utils.hpp 0.00% <0.00%> (ø)
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin
Copy link
Contributor Author

soblin commented Sep 14, 2022

cc: @kyoichi-sugahara

@soblin soblin enabled auto-merge (squash) September 14, 2022 10:00
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
…e reaches the goal (autowarefoundation#1818)""

This reverts commit e68f86b.

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin merged commit 89154c9 into autowarefoundation:main Sep 20, 2022
@soblin soblin deleted the feat/intersection-area branch September 20, 2022 10:33
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
soblin added a commit to soblin/autoware.universe that referenced this pull request Dec 22, 2022
soblin added a commit to soblin/autoware.universe that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants