Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tensorrt_yolo): update Readme about model conversion #1749

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

HaoruXue
Copy link
Contributor

@HaoruXue HaoruXue commented Sep 1, 2022

Description

I added a couple lines in readme to avoid confusion on the model downloading.

Closes #1647

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HaoruXue HaoruXue requested a review from wep21 as a code owner September 1, 2022 00:22
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 10.33% // Head: 10.33% // No change to project coverage 👍

Coverage data is based on head (44674c1) compared to base (1cc2a07).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1749   +/-   ##
=======================================
  Coverage   10.33%   10.33%           
=======================================
  Files        1146     1146           
  Lines       81591    81591           
  Branches    19049    19049           
=======================================
  Hits         8434     8434           
  Misses      64036    64036           
  Partials     9121     9121           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.31% <ø> (ø) Carriedforward from 1cc2a07

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wep21 wep21 changed the title feat(tensorrt_yolo) Update Readme about model conversion feat(tensorrt_yolo): update Readme about model conversion Sep 1, 2022
@wep21
Copy link
Contributor

wep21 commented Sep 1, 2022

@HaoruXue Thank you for your modification. Could you make the commit message same as the PR title to pass semantic-pull-request check?

@yukke42 yukke42 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 2, 2022
@xmfcx xmfcx force-pushed the patch-1 branch 2 times, most recently from 91a4140 to b916444 Compare September 20, 2022 16:12
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit ac68c06 into autowarefoundation:main Sep 20, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensorrt_yolo sample yolov5 model throw error on inference
4 participants