Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): replace interpolation function with the utils function #1798

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 6, 2022

Signed-off-by: yutaka [email protected]

Description

In this PR, I replaced the calcInterpolatePoint function with the same function in the motion_utils package.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1798 (5700889) into main (574be20) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   10.41%   10.39%   -0.03%     
==========================================
  Files        1218     1218              
  Lines       87479    87668     +189     
  Branches    20479    20479              
==========================================
  Hits         9111     9111              
- Misses      68893    69082     +189     
  Partials     9475     9475              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.40% <0.00%> (ø) Carriedforward from 574be20

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ation_based_planner/optimization_based_planner.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 505f975 into autowarefoundation:main Sep 7, 2022
@purewater0901 purewater0901 deleted the feat/use-util-interpolation branch September 7, 2022 00:22
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…e utils function (autowarefoundation#1798)

* feat(obstacle_cruise_planner): replace interpolation function with the util function

Signed-off-by: yutaka <[email protected]>

* add dist and yaw threshold

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…e utils function (autowarefoundation#1798)

* feat(obstacle_cruise_planner): replace interpolation function with the util function

Signed-off-by: yutaka <[email protected]>

* add dist and yaw threshold

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…e utils function (autowarefoundation#1798)

* feat(obstacle_cruise_planner): replace interpolation function with the util function

Signed-off-by: yutaka <[email protected]>

* add dist and yaw threshold

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…e utils function (autowarefoundation#1798)

* feat(obstacle_cruise_planner): replace interpolation function with the util function

Signed-off-by: yutaka <[email protected]>

* add dist and yaw threshold

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants