Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vehicle_info_util): add script to calculate turning radius #1855

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 13, 2022

Description

add script to calculate max turning radius

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review September 13, 2022 09:20
@takayuki5168 takayuki5168 added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 13, 2022
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

@YamatoAndo @TakaHoribe Could you review this

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 10.42% // Head: 10.36% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (7e6e8ed) compared to base (19ce83b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
- Coverage   10.42%   10.36%   -0.07%     
==========================================
  Files        1226     1224       -2     
  Lines       87945    88540     +595     
  Branches    20455    20990     +535     
==========================================
+ Hits         9171     9179       +8     
- Misses      69270    69801     +531     
- Partials     9504     9560      +56     
Flag Coverage Δ *Carryforward flag
differential 8.61% <0.00%> (?)
total 10.45% <0.00%> (+0.03%) ⬆️ Carriedforward from 49ab5ab

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...anner/include/scene_module/traffic_light/scene.hpp 0.00% <ø> (ø)
...y_planner/src/scene_module/traffic_light/scene.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 2.71% <0.00%> (-0.42%) ⬇️
control/shift_decider/src/shift_decider.cpp 0.00% <0.00%> (ø)
simulator/dummy_perception_publisher/src/node.cpp 0.00% <0.00%> (ø)
...ier4_perception_rviz_plugin/src/tools/car_pose.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
..._perception_rviz_plugin/src/tools/unknown_pose.cpp 0.00% <0.00%> (ø)
...rception_rviz_plugin/src/tools/pedestrian_pose.cpp 0.00% <0.00%> (ø)
...ption_rviz_plugin/src/tools/interactive_object.cpp 0.00% <0.00%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

max_steer_angle = config["/**"]["ros__parameters"]["max_steer_angle"]

print("yaml path is {}".format(yaml_path))
print("Minimum turning radius is {} [m]".format(wheel_base / math.sin(max_steer_angle)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to show the definition of the radius since the formula depends on how you define the radius. If it is for the rear wheel, the equation should be

radius = wheel_base / tan(steer)

If it is for front steer, it will be

radius = wheel_base / sin(steer)

Maybe it is nice to print both, like

Minimum turning radius is 4.40 [m] for rear, 4.45[m] for front

Copy link
Contributor Author

@takayuki5168 takayuki5168 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the better idea.

50746d6
DONE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Signed-off-by: Takayuki Murooka <[email protected]>
@YamatoAndo
Copy link
Contributor

I'll leave the review up to @TakaHoribe 🙇

@TakaHoribe TakaHoribe self-requested a review September 14, 2022 11:46
@TakaHoribe TakaHoribe self-requested a review September 14, 2022 11:47
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takayuki5168
Copy link
Contributor Author

@YamatoAndo
I'm not sure if your approval is required to merge this PR, but could you approve?
image

Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 799a02a into autowarefoundation:main Sep 16, 2022
@takayuki5168 takayuki5168 deleted the feat/vehicle-info-scripts branch September 16, 2022 11:46
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants