-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ModelZoo): rework prebuilt assets management #1880
feat(ModelZoo): rework prebuilt assets management #1880
Conversation
862c66a
to
d7565c2
Compare
Codecov ReportBase: 10.78% // Head: 10.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1880 +/- ##
==========================================
- Coverage 10.78% 10.37% -0.41%
==========================================
Files 1179 1163 -16
Lines 84449 82840 -1609
Branches 19795 19287 -508
==========================================
- Hits 9104 8594 -510
+ Misses 65853 64976 -877
+ Partials 9492 9270 -222
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@ambroise-arm |
ModelZoo artifacts changed from a single archive to one archive per model/backend combination. It allows users to only download needed archives, but prevents keeping the current design. Change from all models being handled by the "neural_networks_provider" package to models being downloaded by packages that need them. Leverage the newly added versioning of the prebuilt models. Fix the NN check of the "nodes" package. Issue-Id: SCM-3999 Signed-off-by: Ambroise Vincent <[email protected]> Change-Id: I1df9007f5bf446a8b50e38c4fd98e9e3a8d2550f
0bdcf51
to
c6f96a9
Compare
@angry-crab Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ModelZoo artifacts changed from a single archive to one archive per model/backend combination. It allows users to only download needed archives, but prevents keeping the current design.
Change from all models being handled by the "neural_networks_provider" package to models being downloaded by packages that need them.
Leverage the newly added versioning of the prebuilt models.
Related links
Part of #1879
Tests performed
Tested locally by building the TVM packages with
--cmake-args -DDOWNLOAD_ARTIFACTS=ON
and running the unit tests of those packages.Notes for reviewers
#1181 needs to be merged first.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.