Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move adapi rviz adaptor #1900

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 16, 2022

Signed-off-by: Takagi, Isamu [email protected]

Description

Move adapi adaptor to add a dedicated launch flag.
autowarefoundation/autoware#2868
autowarefoundation/autoware_launch#88

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi changed the title Move adapi rviz adaptor feat: move adapi rviz adaptor Sep 16, 2022
@isamu-takagi isamu-takagi changed the title feat: move adapi rviz adaptor feat: move adapi rviz adaptor Sep 16, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) September 18, 2022 12:54
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@isamu-takagi
Copy link
Contributor Author

This is probably the cause of this issue. #1907

@kenji-miyake kenji-miyake merged commit f27d7ea into autowarefoundation:main Sep 20, 2022
@isamu-takagi isamu-takagi deleted the feature/move-adapi-rviz-adaptor branch September 20, 2022 06:53
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
feat: move adapi rviz adaptor

Signed-off-by: Takagi, Isamu <[email protected]>

Signed-off-by: Takagi, Isamu <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
feat: move adapi rviz adaptor

Signed-off-by: Takagi, Isamu <[email protected]>

Signed-off-by: Takagi, Isamu <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
feat: move adapi rviz adaptor

Signed-off-by: Takagi, Isamu <[email protected]>

Signed-off-by: Takagi, Isamu <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
feat: move adapi rviz adaptor

Signed-off-by: Takagi, Isamu <[email protected]>

Signed-off-by: Takagi, Isamu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants