fix(route_handler): deal with completely overlapped inverted lane #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
|
@zulfaqar-azmi-t4 Could you review this. |
|
I confirmed that the non-overlaped inverted lane was successfully calculated with this PR. |
Codecov ReportBase: 10.44% // Head: 10.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 10.44% 10.41% -0.04%
==========================================
Files 1233 1233
Lines 88034 88334 +300
Branches 20501 20722 +221
==========================================
Hits 9197 9197
- Misses 69328 69614 +286
- Partials 9509 9523 +14
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Sep 28, 2022
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takayuki Murooka [email protected]
Description
support the completely overlapped inverted lane.
Without this PR, the route handler will have infinity loop process in the case with completely overlapped inverted lane
(get right bound of inverted lane -> get left bound of inverted lane -> get right bound of inverted lane -> ...)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.