-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(route_handler): deal with completely overlapped inverted lane #1901
fix(route_handler): deal with completely overlapped inverted lane #1901
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
@zulfaqar-azmi-t4 Could you review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 10.44% // Head: 10.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 10.44% 10.41% -0.04%
==========================================
Files 1233 1233
Lines 88034 88334 +300
Branches 20501 20722 +221
==========================================
Hits 9197 9197
- Misses 69328 69614 +286
- Partials 9509 9523 +14
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
…towarefoundation#1901) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka [email protected]
Description
support the completely overlapped inverted lane.
Without this PR, the route handler will have infinity loop process in the case with completely overlapped inverted lane
(get right bound of inverted lane -> get left bound of inverted lane -> get right bound of inverted lane -> ...)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.