Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(accel_brake_map_calibrator): add parameter descriptions #1918

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 21, 2022

Description

  • Add parameter description in the readme
  • remove unused parameter

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe enabled auto-merge (squash) September 21, 2022 02:26
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 10.34% // Head: 10.30% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (de6bc8f) compared to base (a63ed16).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1918      +/-   ##
==========================================
- Coverage   10.34%   10.30%   -0.04%     
==========================================
  Files        1146     1146              
  Lines       81464    81780     +316     
  Branches    19003    19003              
==========================================
  Hits         8429     8429              
- Misses      63915    64231     +316     
  Partials     9120     9120              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.32% <ø> (ø) Carriedforward from a63ed16

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...map_calibrator/accel_brake_map_calibrator_node.hpp 0.00% <ø> (ø)
...calibrator/src/accel_brake_map_calibrator_node.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit 478c759 into autowarefoundation:main Sep 21, 2022
@TakaHoribe TakaHoribe deleted the update-readme-map-calibrator branch September 21, 2022 02:32
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…efoundation#1918)

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused value

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…efoundation#1918)

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused value

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…efoundation#1918)

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused value

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…efoundation#1918)

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused value

Signed-off-by: Takamasa Horibe <[email protected]>

* update readme

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants