Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default_ad_api): temporary disable api route to resolve type conflict #1928

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 21, 2022

Signed-off-by: Takagi, Isamu [email protected]

Description

This is temporary fix for #1927. Related to #1495.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 10.40% // Head: 10.40% // No change to project coverage 👍

Coverage data is based on head (66dac6c) compared to base (d85da95).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   10.40%   10.40%           
=======================================
  Files        1146     1146           
  Lines       78041    78041           
  Branches    18798    18798           
=======================================
  Hits         8121     8121           
  Misses      61085    61085           
  Partials     8835     8835           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.40% <0.00%> (ø) Carriedforward from d85da95

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (ø)
system/default_ad_api/src/routing.cpp 33.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi merged commit e2c5eda into autowarefoundation:main Sep 21, 2022
@isamu-takagi isamu-takagi deleted the fix/ad-api/temporary-disable-api-route-for-type-conflict branch September 21, 2022 11:57
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants