-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): pull over dies after curve #1963
fix(behavior_path_planner): pull over dies after curve #1963
Conversation
Signed-off-by: kosuke55 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 10.27% // Head: 10.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
- Coverage 10.27% 10.26% -0.02%
==========================================
Files 1154 1154
Lines 82071 82158 +87
Branches 19102 19157 +55
==========================================
Hits 8436 8436
- Misses 64492 64572 +80
- Partials 9143 9150 +7
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
…ation#1963) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 [email protected]
Description
pull_over dies when putting goal in the immediate beginning of shoulder_lane (especially after curve)
This problem is caused by
Related links
Tests performed
psim
pull_over does not die.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.