Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lidar_centerpoint): refactor isCarLikeVehicle function #2030

Merged

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Oct 6, 2022

Signed-off-by: scepter914 [email protected]

Description

Replace isCarLikeVehicle() function to perception_util.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 10.42% // Head: 10.42% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0e0a939) compared to base (5549db4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
- Coverage   10.42%   10.42%   -0.01%     
==========================================
  Files        1167     1167              
  Lines       83342    83364      +22     
  Branches    19549    19549              
==========================================
  Hits         8690     8690              
- Misses      65150    65172      +22     
  Partials     9502     9502              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.41% <0.00%> (ø) Carriedforward from 5549db4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/lidar_centerpoint/lib/ros_utils.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 4d85af2 into autowarefoundation:main Oct 11, 2022
@scepter914 scepter914 deleted the refactor/centerpoint_label branch October 11, 2022 03:18
scepter914 added a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants