-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: missing topic info duration 1000 -> 5000 #2056
chore: missing topic info duration 1000 -> 5000 #2056
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
Let me know if 5000 is too low. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5000 is enough for me when testing it on the real environment.
Codecov ReportBase: 10.44% // Head: 10.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
- Coverage 10.44% 10.16% -0.28%
==========================================
Files 1163 1164 +1
Lines 83164 85617 +2453
Branches 19546 21305 +1759
==========================================
+ Hits 8686 8703 +17
- Misses 64974 67240 +2266
- Partials 9504 9674 +170
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: scepter914 <[email protected]>
Signed-off-by: Takayuki Murooka [email protected]
Description
Currently, duration of debug print for missing topics is too high.
Therefore, I made them low (1000 -> 5000).
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.