Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_collision_checker): fix bug on dynamic parameter update #2183

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Oct 31, 2022

Signed-off-by: Berkay Karaman [email protected]

Description

Issue: #2143
Related: #2153

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 self-assigned this Oct 31, 2022
@brkay54 brkay54 marked this pull request as draft October 31, 2022 13:45
@brkay54 brkay54 marked this pull request as ready for review October 31, 2022 13:46
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 10.84% // Head: 10.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b55bcd3) compared to base (89fef41).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2183      +/-   ##
==========================================
- Coverage   10.84%   10.83%   -0.01%     
==========================================
  Files        1178     1178              
  Lines       84780    84867      +87     
  Branches    19952    20012      +60     
==========================================
+ Hits         9196     9197       +1     
- Misses      65879    65961      +82     
- Partials     9705     9709       +4     
Flag Coverage Δ *Carryforward flag
differential 7.22% <0.00%> (?)
total 10.82% <0.00%> (ø) Carriedforward from 89fef41

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ning_rviz_plugin/src/path_with_lane_id/display.cpp 0.00% <0.00%> (ø)
...r4_planning_rviz_plugin/src/trajectory/display.cpp 0.00% <0.00%> (ø)
...n_checker_node/obstacle_collision_checker_node.cpp 0.88% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brkay54 brkay54 merged commit dd39b5d into autowarefoundation:main Nov 1, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…utowarefoundation#2183)

Signed-off-by: Berkay Karaman <[email protected]>

Signed-off-by: Berkay Karaman <[email protected]>
Co-authored-by: Berkay Karaman <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
@brkay54 brkay54 deleted the bug-fix-occ branch April 27, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants