Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt_yolo): multi gpu on component container #2297

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

kaancolak
Copy link
Contributor

@kaancolak kaancolak commented Nov 15, 2022

Signed-off-by: Kaan Colak [email protected]

When working with tensorrt_yolo on multiple GPU device without compostable node container everything works fine.

But when I use tensorrt_ yolo as a component nodelet, if gpu_device is set to another then 0 tensorrt_yolo gives seg fault.

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kaancolak kaancolak self-assigned this Nov 15, 2022
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 15, 2022
@kaancolak
Copy link
Contributor Author

Hello, @wep21 Nithimatsu-san and, @yukkysaito Saito-san,

Could you review this PR? Do you have any opinion or alternative solution?

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 10.55% // Head: 10.55% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (302a053) compared to base (3d714ac).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
- Coverage   10.55%   10.55%   -0.01%     
==========================================
  Files        1256     1256              
  Lines       91029    91048      +19     
  Branches    20790    20790              
==========================================
  Hits         9611     9611              
- Misses      71260    71279      +19     
  Partials    10158    10158              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.53% <0.00%> (ø) Carriedforward from f249684

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaancolak kaancolak requested a review from a team as a code owner November 21, 2022 13:20
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 21, 2022
@kaancolak kaancolak requested a review from wep21 November 21, 2022 13:21
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xmfcx @yukkysaito Do you have another comment?

@xmfcx xmfcx added this to the Bus ODD Nov-Dec Milestone milestone Nov 29, 2022
@xmfcx xmfcx merged commit cedc520 into autowarefoundation:main Nov 29, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…ion#2297)

Signed-off-by: Kaan Colak <[email protected]>
Signed-off-by: Kaan Çolak <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants