feat(behavior_velocity_planner): output stop reason of traffic light whenever a stop point is inserted #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whenever a stop point is inserted Signed-off-by: tomoya.kimura <[email protected]>
tkimura4
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo,
purewater0901 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportBase: 10.48% // Head: 10.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
- Coverage 10.48% 10.48% -0.01%
==========================================
Files 1249 1249
Lines 90888 90910 +22
Branches 20860 20870 +10
==========================================
Hits 9531 9531
- Misses 71229 71250 +21
- Partials 10128 10129 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
h-ohta
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2022
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]>
4 tasks
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2022
…whenever a stop point is inserted (backport autowarefoundation#2323) (#209) feat(behavior_velocity_planner): output stop reason of traffic light whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]>
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: kminoda <[email protected]>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…whenever a stop point is inserted (autowarefoundation#2323) Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: yoshiri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current implementation, when the car stops by the traffic light module and its stop reason is RTC, the
stop_reasonsof traffic light is not output.As other behavior modules, I changed that in cases like the above
stop_reasonswith emptystop_factor_pointsis output.Review
1,
Comment out
default_enable_list."traffic_light"in rtc_auto_mode_manager.param.yamlSet a route including stop lines for traffic lights
Confirm the stop_reason of traffic light is output
ros2 topic echo /planning/scenario_planning/status/stop_reasons|grep TrafficLight -A 11
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.