Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): fix lane change drivable lanes #2324

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Nov 18, 2022

Description

In some cases, it cannot generate correct drivable lanes. In this PR, I fixed the issue and checked it does work well.

simplescreenrecorder-2022-11-19_00.55.13.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 10.47% // Head: 10.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b1940e6) compared to base (9929e9c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
- Coverage   10.47%   10.47%   -0.01%     
==========================================
  Files        1250     1250              
  Lines       90971    90982      +11     
  Branches    20916    20923       +7     
==========================================
  Hits         9532     9532              
- Misses      71446    71455       +9     
- Partials     9993     9995       +2     
Flag Coverage Δ *Carryforward flag
differential 3.23% <0.00%> (?)
total 10.45% <0.00%> (ø) Carriedforward from 9929e9c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4
Copy link
Contributor

Before PR

b4_pr.mp4

After PR

after_pr.mp4

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function works great!
LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 523b77f into autowarefoundation:main Nov 19, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix/lane-change-drivable-lanes branch November 19, 2022 02:24
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…foundation#2324)

* fix(behavior_path_planner): delete unnecessary codes

Signed-off-by: yutaka <[email protected]>

* feat(behavior_path_planner): fix lane change drivable lanes

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
Signed-off-by: kminoda <[email protected]>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…foundation#2324)

* fix(behavior_path_planner): delete unnecessary codes

Signed-off-by: yutaka <[email protected]>

* feat(behavior_path_planner): fix lane change drivable lanes

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants