fix(behavior_path_planner): use SUCCESS instead of IDLE when onExit #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <[email protected]>
kosuke55
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
7 tasks
kosuke55
commented
Nov 28, 2022
| @@ -184,7 +184,6 @@ void PullOverModule::onExit() | |||
| steering_factor_interface_ptr_->clearSteeringFactors(); | |||
|
|
|||
| // A child node must never return IDLE | |||
| // https://github.com/BehaviorTree/BehaviorTree.CPP/blob/master/include/behaviortree_cpp_v3/basic_types.h#L34 | |||
There was a problem hiding this comment.
the link is already invalid now.
it moved to https://github.com/BehaviorTree/BehaviorTree.CPP/blob/master/include/behaviortree_cpp/basic_types.h#L35, but remove it considering the maintenance cost
Codecov ReportBase: 10.61% // Head: 10.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
- Coverage 10.61% 10.55% -0.07%
==========================================
Files 1241 1242 +1
Lines 83131 83742 +611
Branches 20459 20670 +211
==========================================
+ Hits 8823 8836 +13
- Misses 64596 65016 +420
- Partials 9712 9890 +178
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…utowarefoundation#2391) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…utowarefoundation#2391) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kminoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kosuke55 [email protected]
Description
From the flowing comment, it seems better to use Success instead of Idle.
https://github.com/BehaviorTree/BehaviorTree.CPP/blob/master/include/behaviortree_cpp/basic_types.h#L35
/// IMPORTANT: Your custom nodes should NEVER return IDLE.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.