Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multi_object_tracker): clean up noisy tf warning message on terminal #2511

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Dec 16, 2022

Description

Not to display tons of warning messages on terminal.

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe requested review from yukkysaito and a team as code owners December 16, 2022 04:32
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 16, 2022
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 10.56% // Head: 10.55% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (9b740b7) compared to base (6731e0c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2511      +/-   ##
==========================================
- Coverage   10.56%   10.55%   -0.01%     
==========================================
  Files        1265     1265              
  Lines       87435    87512      +77     
  Branches    20940    20940              
==========================================
  Hits         9238     9238              
- Misses      68310    68387      +77     
  Partials     9887     9887              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (ø) Carriedforward from 6731e0c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe enabled auto-merge (squash) December 16, 2022 05:00
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit fc1d820 into autowarefoundation:main Dec 17, 2022
@TakaHoribe TakaHoribe deleted the refactor-multi-object-tf-error-msg branch December 17, 2022 11:28
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…terminal (autowarefoundation#2511)

* refactor(multi_object_tracker): clean noisy tf warning message

Signed-off-by: Takamasa Horibe <[email protected]>

* enable code

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants