Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light_map_based_detector): remove pedestrain traffic lights which should not be extracted from map #2574

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

Mingyu1991
Copy link
Contributor

Issue

https://tier4.atlassian.net/browse/T4PB-24735

Description

  • Some virtual pedestrain traffic lights are saved in the map and be extracted as traffic light when traffic_light_map_based_detector is calculating the rough rois. This PR would prevent these virtual traffic lights from being used in following process.

@Mingyu1991 Mingyu1991 requested review from yukkysaito and a team as code owners December 23, 2022 04:09
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 11.38% // Head: 11.38% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1fb27f6) compared to base (333e1c5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   11.38%   11.38%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       89211    89254      +43     
  Branches    23610    23610              
==========================================
  Hits        10160    10160              
- Misses      68278    68321      +43     
  Partials    10773    10773              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.38% <0.00%> (ø) Carriedforward from 333e1c5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tion/traffic_light_map_based_detector/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mingyu1991 Mingyu1991 enabled auto-merge (squash) January 12, 2023 10:50
@miursh
Copy link
Contributor

miursh commented Jan 13, 2023

@Mingyu1991 Could you resolve CI errors?
image
image
image

@Mingyu1991 Mingyu1991 changed the title remove pedestrain traffic lights which should not be extracted from map <fix>(traffic_light_map_based_detector): remove pedestrain traffic lights which should not be extracted from map Jan 13, 2023
@Mingyu1991 Mingyu1991 changed the title <fix>(traffic_light_map_based_detector): remove pedestrain traffic lights which should not be extracted from map fix(traffic_light_map_based_detector): remove pedestrain traffic lights which should not be extracted from map Jan 13, 2023
td12321 and others added 2 commits January 13, 2023 17:11
…utowarefoundation#2466)

* add calibration_method description.

* apply formatter

Signed-off-by: takahoribe <[email protected]>

* update doc

Signed-off-by: takahoribe <[email protected]>

Signed-off-by: takahoribe <[email protected]>
Co-authored-by: takahoribe <[email protected]>
Signed-off-by: mingyu.li <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Jan 13, 2023
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Jan 13, 2023
@Mingyu1991 Mingyu1991 merged commit 64285f3 into autowarefoundation:main Jan 13, 2023
@Mingyu1991
Copy link
Contributor Author

@miursh Done.

@Mingyu1991 Mingyu1991 deleted the tmp/traffic_light branch January 17, 2023 14:41
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants