Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): fix drivable area checker #2639

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jan 12, 2023

Description

Currently, the obstacle avoidance planner checks if the footprint of the vehicle is outside of the drivable area by lateral distance from the left and right boundary. However, this method does not work well when the boundary is not straight. In this PR, I use the polygon instead of the line to check if the footprint is outside of the drivable area.

For example, in the following scene, the trajectory point will be judged outside of the drivable area even though it is inside of it. This is because it uses the line created by point0 and point1, so the trajectory point is judged to be located right side of the line.
IMG_0350

Related links

Inernal Test Result 821/825

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901 purewater0901 changed the title Fix/drivable area checker fix(obstacle_avoidance_planner): fix drivable area checker Jan 12, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 12, 2023
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 11.39% // Head: 12.18% // Increases project coverage by +0.79% 🎉

Coverage data is based on head (68a4f59) compared to base (33ecdb5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
+ Coverage   11.39%   12.18%   +0.79%     
==========================================
  Files        1279     1179     -100     
  Lines       89170    83565    -5605     
  Branches    23587    23676      +89     
==========================================
+ Hits        10161    10185      +24     
+ Misses      68239    62597    -5642     
- Partials    10770    10783      +13     
Flag Coverage Δ *Carryforward flag
differential 17.58% <0.00%> (?)
total 12.18% <0.00%> (+0.78%) ⬆️ Carriedforward from 33ecdb5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/obstacle_avoidance_planner/utils/utils.hpp 36.47% <ø> (ø)
...ing/obstacle_avoidance_planner/src/utils/utils.cpp 12.55% <0.00%> (+1.56%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 85.71% <0.00%> (-2.39%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...rt_yolox/src/yolox_single_image_inference_node.cpp
...ec_vendor/_deps/tensorrt-src/samples/common/half.h
perception/tensorrt_yolo/src/nodelet.cpp
..._vendor/_deps/tensorrt-src/samples/common/common.h
...enterpoint/postprocess/non_maximum_suppression.hpp
...on/lidar_centerpoint/lib/network/scatter_kernel.cu
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit d91f84e into autowarefoundation:main Jan 13, 2023
@purewater0901 purewater0901 deleted the fix/drivable-area-checker branch January 13, 2023 01:47
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 13, 2023
…oundation#2639)

* fix(obstacle_avoidance_planner): fix drivable area checker

Signed-off-by: yutaka <[email protected]>

* fix format

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 13, 2023
…oundation#2639) (#243)

* fix(obstacle_avoidance_planner): fix drivable area checker

Signed-off-by: yutaka <[email protected]>

* fix format

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
Co-authored-by: Yutaka Shimizu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants