Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(behavior velocity): fix unstable gtest #273

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion planning/behavior_velocity_planner/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,6 @@ if(BUILD_TESTING)
test/src/test_risk_predictive_braking.cpp
test/src/test_geometry.cpp
test/src/test_grid_utils.cpp
test/src/test_performances.cpp
)
target_link_libraries(occlusion_spot-test
gtest_main
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ TEST(buildPathLanelet, nominal)
std::cout << "path lanelet size: " << path_lanelet.centerline2d().size() << std::endl;
}

TEST(calcSlowDownPointsForPossibleCollision, TooManyPossibleCollisions)
TEST(calcSlowDownPointsForPossibleCollision, ManyPossibleCollisions)
{
using behavior_velocity_planner::occlusion_spot_utils::calcSlowDownPointsForPossibleCollision;
using behavior_velocity_planner::occlusion_spot_utils::PossibleCollisionInfo;
Expand All @@ -76,11 +76,12 @@ TEST(calcSlowDownPointsForPossibleCollision, TooManyPossibleCollisions)
using std::chrono::high_resolution_clock;
using std::chrono::microseconds;
std::vector<PossibleCollisionInfo> possible_collisions;
size_t num = 2000;
// make a path with 2000 points from x=0 to x=4
autoware_auto_planning_msgs::msg::PathWithLaneId path =
test::generatePath(0.0, 3.0, 4.0, 3.0, 2000);
test::generatePath(0.0, 3.0, 4.0, 3.0, num);
// make 2000 possible collision from x=0 to x=10
test::generatePossibleCollisions(possible_collisions, 0.0, 3.0, 4.0, 3.0, 2000);
test::generatePossibleCollisions(possible_collisions, 0.0, 3.0, 4.0, 3.0, num);

/**
* @brief too many possible collisions on path
Expand All @@ -94,9 +95,8 @@ TEST(calcSlowDownPointsForPossibleCollision, TooManyPossibleCollisions)

auto end_naive = high_resolution_clock::now();
// 2000 path * 2000 possible collisions
EXPECT_EQ(possible_collisions.size(), size_t{2000});
EXPECT_EQ(path.points.size(), size_t{2000});
EXPECT_TRUE(duration_cast<microseconds>(end_naive - start_naive).count() < 2000);
EXPECT_EQ(possible_collisions.size(), size_t{num});
EXPECT_EQ(path.points.size(), size_t{num});
std::cout << " runtime (microsec) "
<< duration_cast<microseconds>(end_naive - start_naive).count() << std::endl;
}
Expand Down Expand Up @@ -136,7 +136,7 @@ TEST(calcSlowDownPointsForPossibleCollision, ConsiderSignedOffset)
EXPECT_EQ(possible_collisions[2].collision_path_point.longitudinal_velocity_mps, 6);
}

TEST(createPossibleCollisionBehindParkedVehicle, TooManyPathPointsAndObstacles)
TEST(createPossibleCollisionBehindParkedVehicle, PathPointsAndObstacles)
{
using behavior_velocity_planner::occlusion_spot_utils::createPossibleCollisionBehindParkedVehicle;
using std::chrono::duration;
Expand Down Expand Up @@ -171,7 +171,7 @@ TEST(createPossibleCollisionBehindParkedVehicle, TooManyPathPointsAndObstacles)
obj.kinematics.initial_pose_with_covariance.pose.position.x = 2.5;
obj.kinematics.initial_pose_with_covariance.pose.position.y = 4.0;
obj.classification.at(0).label = autoware_auto_perception_msgs::msg::ObjectClassification::CAR;
const size_t num_car = 30;
const size_t num_car = 3;
for (size_t i = 0; i < num_car; i++) {
obj_arr.objects.emplace_back(obj);
}
Expand Down
69 changes: 0 additions & 69 deletions planning/behavior_velocity_planner/test/src/test_performances.cpp

This file was deleted.