Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interpolation): add option to enable akima spline for xy #2802

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 2, 2023

Signed-off-by: Takayuki Murooka [email protected]

Description

No behavior change with this PR.
I replaced the option of use_lerp_for_xy with use_akima_spline_for_xy, which is false by default.

I confirmed that use_lerp_for_xy is not used in any planning package.

background
Spline interpolation for 2d position sometimes generates unexpected wave as follows.
image

(If use_akima_spline_for_xy is true) With akima spline, this wave can be removed.
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 2, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 2, 2023 11:14
@takayuki5168
Copy link
Contributor Author

@purewater0901 Could you review the PR.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 11.63% // Head: 11.71% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (b311805) compared to base (d6c0c09).
Patch coverage: 72.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
+ Coverage   11.63%   11.71%   +0.08%     
==========================================
  Files        1317     1317              
  Lines       91839    91969     +130     
  Branches    24382    24490     +108     
==========================================
+ Hits        10681    10778      +97     
- Misses      70007    70008       +1     
- Partials    11151    11183      +32     
Flag Coverage Δ *Carryforward flag
differential 12.85% <20.00%> (?)
total 11.63% <100.00%> (ø) Carriedforward from d6c0c09

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/resample/resample.cpp 43.79% <72.22%> (+11.76%) ⬆️
...ne_optimizer/src/collision_free_optimizer_node.cpp 23.01% <0.00%> (+0.41%) ⬆️
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 44.13% <0.00%> (+0.58%) ⬆️
...ing/obstacle_avoidance_planner/src/utils/utils.cpp 10.59% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit a3de486 into autowarefoundation:main Feb 2, 2023
@takayuki5168 takayuki5168 deleted the feat/enable-akima-spline-for-xy branch February 2, 2023 15:17
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
keita1523 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 8, 2023
keita1523 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants