Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation): fix unuse_time_series_filter bug #2824

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Feb 7, 2023

Signed-off-by: badai-nguyen [email protected]

Description

There is no any node publishes /perception/obstacle_segmentation output_topic when both use_time_series_filter and use_single_frame_filter set to false

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 7, 2023
@badai-nguyen badai-nguyen marked this pull request as ready for review February 7, 2023 04:24
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit d3918e7 into autowarefoundation:main Feb 7, 2023
@badai-nguyen badai-nguyen deleted the fix/ground_segmentation_unuse_time_series_filter_bugfix branch February 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants