Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix the reason of behind threshold #2851

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 9, 2023

Signed-off-by: Takayuki Murooka [email protected]

Description

The reason for unavoidance was set wrong.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 9, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 9, 2023 02:19
@takayuki5168
Copy link
Contributor Author

@satoshi-ota Could you review the PR.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 11.62% // Head: 11.62% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2fb4c1a) compared to base (14979d0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
- Coverage   11.62%   11.62%   -0.01%     
==========================================
  Files        1321     1321              
  Lines       92140    92143       +3     
  Branches    24443    24446       +3     
==========================================
  Hits        10714    10714              
- Misses      70244    70247       +3     
  Partials    11182    11182              
Flag Coverage Δ *Carryforward flag
differential 4.69% <0.00%> (?)
total 11.62% <ø> (+<0.01%) ⬆️ Carriedforward from 14979d0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.16% <0.00%> (-0.01%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit efd61ea into autowarefoundation:main Feb 10, 2023
@takayuki5168 takayuki5168 deleted the fix/avoidance-behind-path-goal-reason branch February 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants