Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add traffic signals merge node #2903

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 17, 2023

Description

Add converter node to change the traffic light interface between perception and planning.
This is step 1 of #2567 (comment).

Related links

#2567

Tests performed

  1. Launch planning simulation and use TrafficLightPublishPanel to publish topic from TLR module.
  2. Launch this package
    ros2 launch traffic_light_selector traffic_light_selector.launch.xml
  3. Check merged topic
    ros2 topic echo /perception/traffic_light_selector/traffic_signals

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Feb 17, 2023
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 17, 2023
@isamu-takagi isamu-takagi changed the title Feat/merge traffic light feat: merge traffic signals from perception and V2X Feb 17, 2023
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (06a71f6) 11.93% compared to head (b95cc29) 11.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
- Coverage   11.93%   11.92%   -0.02%     
==========================================
  Files        1321     1323       +2     
  Lines       91941    92024      +83     
  Branches    24525    24525              
==========================================
  Hits        10974    10974              
- Misses      69608    69691      +83     
  Partials    11359    11359              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.93% <ø> (ø) Carriedforward from 2f862d2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...fic_light_selector/src/traffic_light_converter.cpp 0.00% <0.00%> (ø)
...ffic_light_selector/src/traffic_light_selector.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 9, 2023
@isamu-takagi isamu-takagi marked this pull request as ready for review March 9, 2023 12:00
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a temporary implementation, and I approve the assumption that package names, node names, etc. will be changed.

Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi enabled auto-merge (squash) March 10, 2023 08:50
@isamu-takagi isamu-takagi changed the title feat: merge traffic signals from perception and V2X feat: add traffic signals merge node Mar 10, 2023
@isamu-takagi isamu-takagi merged commit e4bcc86 into autowarefoundation:main Mar 10, 2023
@isamu-takagi isamu-takagi deleted the feat/merge-traffic-light branch March 10, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants