Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): add vehicle info api #2984

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Mar 2, 2023

Description

Add vehicle dimension API.

Related links

Tests performed

ros2 service call /api/vehicle/info/dimensions autoware_adapi_v1_msgs/srv/GetVehicleDimensions

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned) labels Mar 2, 2023
@stale
Copy link

stale bot commented May 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 1, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 10, 2023
@isamu-takagi isamu-takagi marked this pull request as ready for review May 10, 2023 08:44
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 10.34% and project coverage change: -0.80 ⚠️

Comparison is base (652d246) 14.43% compared to head (ceb2625) 13.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
- Coverage   14.43%   13.64%   -0.80%     
==========================================
  Files        1462     1397      -65     
  Lines      102964    97057    -5907     
  Branches    29876    28777    -1099     
==========================================
- Hits        14866    13245    -1621     
+ Misses      71865    69480    -2385     
+ Partials    16233    14332    -1901     
Flag Coverage Δ *Carryforward flag
differential 12.43% <10.34%> (?)
total 13.65% <ø> (-0.79%) ⬇️ Carriedforward from 290d3c2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/vehicle_info.cpp 10.34% <10.34%> (ø)

... and 459 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mitsudome-r
Copy link
Member

@isamu-takagi Is the usecase for this API shared somewhere?
I feel uncomfortable adding new APIs without knowing how it is going to be used.

@isamu-takagi isamu-takagi self-assigned this Jun 8, 2023
@isamu-takagi
Copy link
Contributor Author

@isamu-takagi Is the usecase for this API shared somewhere?
I feel uncomfortable adding new APIs without knowing how it is going to be used.

The use cases are added in autowarefoundation/autoware-documentation#381.

@isamu-takagi isamu-takagi enabled auto-merge (squash) June 20, 2023 08:41
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit ec6387a into autowarefoundation:main Jun 26, 2023
@isamu-takagi isamu-takagi deleted the feat/adapi-vehicle-info branch November 22, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants