fix(mpc): optimization failure due to steer limit #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <[email protected]>
github-actions
bot
added
the
component:control
| m_raw_steer_cmd_pprev = current_steer.steering_tire_angle; | ||
| // Consider limit. The prev value larger than limiation brakes the optimization constraint and | ||
| // resluts in optimization failure. | ||
| float steer_lim_f = static_cast<float>(m_steer_lim); |
Signed-off-by: Takamasa Horibe <[email protected]>
takayuki5168
approved these changes
Mar 10, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3044 +/- ##
==========================================
- Coverage 11.93% 11.93% -0.01%
==========================================
Files 1321 1321
Lines 91991 91992 +1
Branches 24566 24568 +2
==========================================
Hits 10978 10978
- Misses 69654 69655 +1
Partials 11359 11359
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MPC optimization sometimes failed when it receives a steering status larger than
mpc_steering_limit. It is due to the break of the optimization constraint.This PR fixes the
prev_steering_valueconsidering the steering limit.Related links
TIERIV COMPANY INTERNAL LINK: https://tier4.atlassian.net/browse/T4PB-26780
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.