Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pull_over): move parameter declare pull over #3048

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 10, 2023

Description

⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#246

  • move parameter declaration to outside of scene module
  • remove default params

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 10, 2023
@satoshi-ota
Copy link
Contributor Author

@kosuke55

@kosuke55
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.82 ⚠️

Comparison is base (def79f3) 12.76% compared to head (3e00b9a) 11.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3048      +/-   ##
==========================================
- Coverage   12.76%   11.95%   -0.82%     
==========================================
  Files        1222     1324     +102     
  Lines       86240    92076    +5836     
  Branches    24627    24616      -11     
==========================================
- Hits        11008    11004       -4     
- Misses      63817    69674    +5857     
+ Partials    11415    11398      -17     
Flag Coverage Δ *Carryforward flag
differential 5.56% <0.00%> (?)
total 11.96% <ø> (-0.80%) ⬇️ Carriedforward from f355882

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._controller/include/mpc_lateral_controller/mpc.hpp 46.66% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 49.72% <ø> (+2.78%) ⬆️
..._lateral_controller/src/mpc_lateral_controller.cpp 34.24% <ø> (-0.31%) ⬇️
control/mpc_lateral_controller/src/mpc_utils.cpp 57.27% <ø> (+0.26%) ⬆️
...ath_planner/util/pull_over/freespace_pull_over.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.13% <0.00%> (-0.01%) ⬇️
...planner/src/util/pull_over/freespace_pull_over.cpp 0.00% <0.00%> (ø)

... and 105 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kosuke55 <[email protected]>
@kosuke55 kosuke55 merged commit e92be64 into autowarefoundation:main Mar 10, 2023
@satoshi-ota satoshi-ota deleted the fix/move-parameter-declare-pull-over branch March 11, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants