Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): remove calcTotalLaneChangeLength function #3483

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 20, 2023

Description

Remove calcTotalLaneChangeLength function to dynamically calculate total lane change length.

🤖 Generated by Copilot at 19f34e4

Refactored the lane change and avoidance logic in the behavior_path_planner package to use a new utility function calcMinimumLaneChangeLength that considers the lateral intervals to the preferred lane. Removed the unused function calcTotalLaneChangeLength from the utils.hpp and utils.cpp files.

Tests performed

Scenario Test Result 1323/1330
TIER4 Internal Link

Effects on system behavior

Total lane change length will be computed dynamically.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2d7470d) 13.81% compared to head (19f34e4) 13.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3483   +/-   ##
=======================================
  Coverage   13.81%   13.81%           
=======================================
  Files        1391     1391           
  Lines       97390    97385    -5     
  Branches    28802    28818   +16     
=======================================
  Hits        13451    13451           
+ Misses      69481    69476    -5     
  Partials    14458    14458           
Flag Coverage Δ *Carryforward flag
differential 12.62% <0.00%> (?)
total 13.81% <ø> (+<0.01%) ⬆️ Carriedforward from 2d7470d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 10.52% <0.00%> (-0.29%) ⬇️
...nner/include/behavior_path_planner/utils/utils.hpp 100.00% <ø> (ø)
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/lane_change/bt_normal.cpp 14.63% <0.00%> (ø)
...ane_change/external_request_lane_change_module.cpp 12.70% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 5.79% <0.00%> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 19.07% <ø> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit ff37c36 into main Apr 20, 2023
@purewater0901 purewater0901 deleted the feat/remove-calc-total-lc-length branch April 20, 2023 16:01
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants