Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): switch default/occlusion_first_stop when occlusion appeared/disappeared or approved/disapproved #3664

Merged
merged 3 commits into from
May 12, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 10, 2023

Description

The temporal stop at the default stopline when occlusion is detected can be activated/deactivated by the RTC with this PR.
To simplify the logic, I removed the uuid for this temporal stop.

Related links

Tests performed

manual mode

If both intersection/intersection_occlusion is set to manual mode, there will be two intersection walls. One is "intersection" and the other is "intersection_occlusion". The "intersection" wall will disappear when deactivated.

manual_mode-2023-05-12_18.23.09.mp4

auto mode

intersection_occlusion works as before.

auto_mode-2023-05-12_18.19.53.mp4

The temporal "intersection" wall will disappear when deactivated.

auto_mode_with_override-2023-05-12_18.21.57.mp4

Notes for reviewers

Interface changes

when running intersection/intersection_occlusion in manual mode

Effects on system behavior

when running intersection/intersection_occlusion in manual mode

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e34253e) 13.77% compared to head (4455539) 13.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3664      +/-   ##
==========================================
- Coverage   13.77%   13.77%   -0.01%     
==========================================
  Files        1400     1400              
  Lines       98952    99011      +59     
  Branches    29347    29397      +50     
==========================================
+ Hits        13633    13635       +2     
- Misses      70514    70572      +58     
+ Partials    14805    14804       -1     
Flag Coverage Δ *Carryforward flag
differential 3.47% <0.00%> (?)
total 13.78% <ø> (+<0.01%) ⬆️ Carriedforward from ae19188

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin force-pushed the fix/intersection-manual-mode branch from 165267f to ff3ae27 Compare May 11, 2023 07:49
@soblin
Copy link
Contributor Author

soblin commented May 12, 2023

@takayuki5168 Please approve this PR.

cc: @tkhmy

@soblin soblin merged commit 8e31521 into autowarefoundation:main May 12, 2023
@soblin soblin deleted the fix/intersection-manual-mode branch May 12, 2023 09:56
soblin added a commit to tier4/autoware.universe that referenced this pull request May 12, 2023
…n appeared/disappeared or approved/disapproved (autowarefoundation#3664)

Signed-off-by: Mamoru Sobue <[email protected]>
shmpwk added a commit to tier4/autoware.universe that referenced this pull request May 15, 2023
feat(intersection): switch default/occlusion_first_stop when occlusion appeared/disappeared or approved/disapproved (autowarefoundation#3664)
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request May 16, 2023
…n appeared/disappeared or approved/disapproved (autowarefoundation#3664)

Signed-off-by: Mamoru Sobue <[email protected]>
soblin added a commit to tier4/autoware.universe that referenced this pull request Jun 13, 2023
…n appeared/disappeared or approved/disapproved (autowarefoundation#3664)

Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants