refactor(joy_controller): rework parameters

[kaspermeck-arm]

Description

Updated adding a schema according to new ROS node config coding guidelines. Implements #2652.

Tests performed

Built-in schema testing in VS Code. Proper JSON Schema and parameter validation tests into the CI are on being developed.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (2da561f) 14.90% compared to head (0ae6933) 14.88%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3992      +/-   ##
==========================================
- Coverage   14.90%   14.88%   -0.02%     
==========================================
  Files        1547     1547              
  Lines      106642   106526     -116     
  Branches    32628    32562      -66     
==========================================
- Hits        15892    15861      -31     
+ Misses      73437    73371      -66     
+ Partials    17313    17294      -19     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	14.88% <ø> (-0.02%)	⬇️	Carriedforward from 9ae9d04

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
...dinal_controller/longitudinal_controller_utils.hpp	35.00% <ø> (ø)
...l_controller/src/longitudinal_controller_utils.cpp	83.05% <ø> (-0.29%)	⬇️
...nal_controller/src/pid_longitudinal_controller.cpp	39.59% <ø> (ø)
...roller/test/test_longitudinal_controller_utils.cpp	52.75% <ø> (-0.61%)	⬇️
...ity_intersection_module/src/scene_intersection.cpp	0.00% <ø> (ø)
...occlusion_spot_module/src/occlusion_spot_utils.cpp	10.82% <ø> (+0.11%)	⬆️
planning/obstacle_cruise_planner/src/node.cpp	12.55% <ø> (+0.07%)	⬆️
...anning/obstacle_velocity_limiter/src/obstacles.cpp	48.14% <ø> (-1.86%)	⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaspermeck-arm]

I've added some validators in the schema where I seemed fit. As I'm not familiar with joy_controller I've made some assumptions. Would be great to get feedback on the one's I've added and the one's I haven't added.

[mitsudome-r]

@kaspermeck-arm
Thanks for the PR, and sorry for the delay with the review.
It seems the package maintainers are busy with other tasks, I made a review instead.

I also had some feedback regarding the use of JSON Schema in general, which I might want to discuss in Open AD Kit WG.

[mitsudome-r]

I was also wondering if we want to set "additionalProperties" to false.
Otherwise, if a developer adds a new parameter to a ROS node and update a yaml file, but forgets to update JSON file, we won't be able to detect that the inconsistency between the YAML file and JSON schema.

[kaspermeck-arm]

@mitsudome-r - thanks for your review! Yes, adding additionalProperties and setting it to false is a good idea. Let's discuss in today's call.

[kaspermeck-arm]

@mitsudome-r - with your new changes, can this PR be merged? Thanks!

[mitsudome-r]

Hi Kasper, have you pushed your changes to the branch?
You have to push to your remote kaspermeck-arm:dojo-ros-config-joy_controller to be reflected to this PR.

[kaspermeck-arm]

Hi Kasper, have you pushed your changes to the branch? You have to push to your remote kaspermeck-arm:dojo-ros-config-joy_controller to be reflected to this PR.

@mitsudome-r - I'm not used to the GitHub PR review system, I misunderstood and thought that you had made changes, not suggestions for changes. My bad! I'll add and push your suggestions to this branch.

[mitsudome-r]

@kaspermeck-arm Thanks for the update. I think we can merge it once #3992 (comment) is resolved.