Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yabloc): fix spell-check 'vectormap' #4379

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix(yabloc): fix spell-check 'vectormap' #4379

merged 2 commits into from
Jul 24, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 24, 2023 •
edited
Loading

Description

Fix spell-check
vectormap -> vector_map

Related links

N/A

Tests performed

N/A

Notes for reviewers

N/A

Interface changes

N/A

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jul 24, 2023
@kminoda kminoda requested a review from KYabuuchi July 24, 2023 06:09
@kminoda kminoda mentioned this pull request Jul 24, 2023
Merged
7 tasks
@kminoda kminoda marked this pull request as ready for review July 24, 2023 06:12
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 24, 2023
@kminoda kminoda enabled auto-merge (squash) July 24, 2023 06:16
@kminoda kminoda self-assigned this Jul 24, 2023
KYabuuchi
KYabuuchi approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is the very last typo 🙏

@kminoda kminoda merged commit 02eeb55 into autowarefoundation:main Jul 24, 2023
30 checks passed
@kminoda
Copy link
Contributor Author

kminoda commented Jul 24, 2023

It is!
https://github.com/autowarefoundation/autoware.universe/actions/runs/5641505733/job/15279666367#step:11:1414

kminoda added a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
@kminoda
fix(yabloc): fix spell-check 'vectormap' (autowarefoundation#4379)
021d852 
* fix(yabloc): fix spell-check

Signed-off-by: kminoda <[email protected]>

* fix(yabloc): fix spell-check 'vectormap'

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 24, 2023
Merged
@kminoda kminoda deleted the fix/yabloc/this_is_the_very_last_typo branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KYabuuchi KYabuuchi KYabuuchi approved these changes

Assignees

@kminoda kminoda

Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kminoda @KYabuuchi