Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(control_validator): changing the frequency of error #4640

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

changing the frequency of error output.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 16, 2023
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d39724) 14.89% compared to head (68cab2d) 14.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4640   +/-   ##
=======================================
  Coverage   14.89%   14.89%           
=======================================
  Files        1547     1547           
  Lines      106605   106598    -7     
  Branches    32602    32595    -7     
=======================================
  Hits        15878    15878           
+ Misses      73423    73416    -7     
  Partials    17304    17304           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from 1d39724

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/control_validator/src/control_validator.cpp 0.00% <0.00%> (ø)
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <ø> (ø)
...planner/src/utils/start_planner/shift_pull_out.cpp 2.96% <ø> (+0.10%) ⬆️
...vior_path_planner/src/utils/start_planner/util.cpp 11.42% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 0b79f4d into autowarefoundation:main Aug 16, 2023
30 of 32 checks passed
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…efoundation#4640)

changing the frequency of error output

Signed-off-by: kyoichi-sugahara <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 21, 2023
…efoundation#4640)

changing the frequency of error output

Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/changing_the_freqency_of_the_error_output branch September 27, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants