Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): consider object velocity direction #4652

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 16, 2023

Description

With the following PR, the vehicle object velocity direction will not be the same as the vehicle object orientation since the velocity center is not the rear wheel center but CoM.
#4637

This PR considers the vehicle object velocity direction in a planning package.

Tests performed

Unit test

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review August 16, 2023 18:14
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 16, 2023
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (5ed7ca3) 14.88% compared to head (0d81c72) 14.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4652      +/-   ##
==========================================
- Coverage   14.88%   14.87%   -0.01%     
==========================================
  Files        1548     1548              
  Lines      106786   106798      +12     
  Branches    32682    32684       +2     
==========================================
  Hits        15891    15891              
- Misses      73587    73599      +12     
  Partials    17308    17308              
Flag Coverage Δ *Carryforward flag
differential 13.23% <0.00%> (?)
total 14.88% <ø> (+<0.01%) ⬆️ Carriedforward from 5ed7ca3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.32% <0.00%> (-0.03%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.01% <0.00%> (-0.02%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 9.42% <0.00%> (-0.02%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.43% <0.00%> (-0.01%) ⬇️
...tacle_stop_planner/src/adaptive_cruise_control.cpp 1.54% <ø> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

planning/behavior_path_planner/src/utils/utils.cpp Outdated Show resolved Hide resolved
@takayuki5168 takayuki5168 force-pushed the feat/behavior-path-consider-object-vel-yaw branch from a8efead to 0d81c72 Compare August 19, 2023 17:02
@satoshi-ota satoshi-ota merged commit f3f8cf5 into autowarefoundation:main Aug 22, 2023
19 of 23 checks passed
@satoshi-ota satoshi-ota deleted the feat/behavior-path-consider-object-vel-yaw branch August 22, 2023 08:59
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…warefoundation#4652)

* feat(behavior_path_planner): consider object velocity direction

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp

---------

Signed-off-by: Takayuki Murooka <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 23, 2023
…warefoundation#4652)

* feat(behavior_path_planner): consider object velocity direction

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants