Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): more stable dynamic drivable area expansion #4677

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Aug 21, 2023

Description

Improve the stability of the drivable area bounds when using the dynamic expansion.
The instability is caused by the path points moving, so this PR adds a resampling of the points at fixed intervals.

Requires the following PR to add the new parameter: autowarefoundation/autoware_launch#522.

Tests performed

Psim and evaluator.

Effects on system behavior

More stable drivable area bounds when using the dynamic expansion.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 30.76% and project coverage change: -0.10% ⚠️

Comparison is base (9b1e4e3) 14.88% compared to head (b440649) 14.79%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4677      +/-   ##
==========================================
- Coverage   14.88%   14.79%   -0.10%     
==========================================
  Files        1549     1549              
  Lines      106958   107876     +918     
  Branches    32791    33435     +644     
==========================================
+ Hits        15925    15958      +33     
- Misses      73639    74424     +785     
- Partials    17394    17494     +100     
Flag Coverage Δ *Carryforward flag
differential 13.25% <30.76%> (?)
total 14.88% <ø> (-0.01%) ⬇️ Carriedforward from 9b1e4e3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 43.75% <ø> (ø)
...anner/utils/drivable_area_expansion/parameters.hpp 19.44% <0.00%> (-0.56%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 26.90% <0.00%> (-0.10%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 15.36% <0.00%> (ø)
...path_planner/test/test_drivable_area_expansion.cpp 32.58% <28.57%> (-0.17%) ⬇️
...rivable_area_expansion/drivable_area_expansion.cpp 37.58% <32.00%> (-0.82%) ⬇️
...r/src/utils/drivable_area_expansion/footprints.cpp 37.50% <50.00%> (ø)
...er/src/utils/drivable_area_expansion/expansion.cpp 34.67% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 834dd07 into autowarefoundation:main Sep 1, 2023
33 of 37 checks passed
@maxime-clem maxime-clem deleted the feat/behavior_path_planner-stable_dyn_da_expansion_universe branch September 1, 2023 01:43
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 15, 2023
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants