-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gnss_poser): rework parameters #4693
refactor(gnss_poser): rework parameters #4693
Conversation
Signed-off-by: PhoebeWu21 <[email protected]>
Signed-off-by: PhoebeWu21 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4693 +/- ##
==========================================
- Coverage 15.32% 14.63% -0.69%
==========================================
Files 1721 1526 -195
Lines 118563 104742 -13821
Branches 37999 31696 -6303
==========================================
- Hits 18170 15333 -2837
+ Misses 79657 72495 -7162
+ Partials 20736 16914 -3822
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@PhoebeWu21 (cc: @YamatoAndo) However, if you don't mind, can we halt this PR and leave this package as it is for a short period of time? The main reason is that this modification may change how parameters are reflected to Essentially, this comes from the duplicated parameter maintenance of some parameters like If you don't mind, I will handle the above major refactoring by myself, so would you do me a favor of holding this PR for a moment? It shouldn't take that much of time, but may take for several weeks if things gets complicated. But definitely doable. |
Got it. Okay! |
This pull request has been automatically marked as stale because it has not had recent activity. |
@kminoda Has your refactoring been completed? If it's done, please let us know. |
@YamatoAndo Thank you for the reminder 🙏 |
@kminoda Okay, thanks! |
Signed-off-by: PhoebeWu21 <[email protected]>
Signed-off-by: PhoebeWu21 <[email protected]>
Signed-off-by: PhoebeWu21 <[email protected]>
* refactor(gnss_poser): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> * refactor(gnss_poser): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> * style(pre-commit): autofix * refactor(gnss_poser): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> * refactor(gnss_poser): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> * refactor(gnss_poser): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> --------- Signed-off-by: PhoebeWu21 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yamato Ando <[email protected]>
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the gnss_poser package.
Tests performed
Package successfully build and launch locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to gnss_poser
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.